Improved setup + platform independence #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC does not support vasprintf. Replaced with all present functions.
If the flag is supplied, the Cython sources will be cleaned ('src'
directory will be removed). Defaults to off since we normally
want to keep them.
Older versions of MSVC (including Visual C++ for Python) does not fully support C99. This change works around the problems by preprocessor defines.
These changes make sure that all setup commands that use a compiler accepts the compiler user option, and that the option is propagated between commands.
These changes makes sure that any user options supplied by `include-dirs`, `library-dirs` and `libraries` to `build_ext` are propagated to `reflect`, and makes sure that `reflect` accepts and uses them.
Conflicts: include/libavutil/avutil.pxd
|
Thanks for what appears to be a considerable effort, and significant improvement to the build system! I'm going to have to go commit-by-commit through this, since I see a few errors (not freeing a new pointer, using a Cheers! |
|
I went commit by commit cherry-picking and fixed a few things here and there (I was wrong about the Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes many smaller issues, and introduces changes that I hope should be straight-forward to accept.