Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support r_rate from ffmpeg r_frame_rate #482

Closed
wants to merge 3 commits into from

Conversation

KengoSawa2
Copy link
Contributor

Hi Thank you great library!!

I am creating a tool to excel metadata with PyAV.

Current PyAV can refer to avg_frame_rate.
However, when displayed with avg_frame_rate, it shows a value different from popular players.
What I confirmed are Mac's QT player, VLC, djv, mediainfo.

Another problem.
When trying to display "TC" by passing avg_frame_rate to the TimeCode library, it tends to be a strange value and it is difficult to use.

For the above two reasons, I think it would be more convenient to make it possible to access r_frame_rate with PyAV.

#319 may be somewhat related(reason is different from me)

@mikeboers
Copy link
Member

I'm considering renaming this attribute as far as Python is concerned.

avg_frame_rate seems reasonable as-is.

Perhaps this should be base_frame_rate and av_guess_frame_rate(...) should be exposed as best_frame_rate or guessed_frame_rate

@mikeboers
Copy link
Member

Gonna keep this going in #564

@mikeboers mikeboers closed this Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants