Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract rendering to separate packages. #11

Open
mikebronner opened this issue Sep 16, 2017 · 2 comments
Open

Abstract rendering to separate packages. #11

mikebronner opened this issue Sep 16, 2017 · 2 comments
Assignees

Comments

@mikebronner
Copy link
Owner

No description provided.

@mikebronner mikebronner added this to the 1.1.0 milestone Sep 16, 2017
@mikebronner mikebronner self-assigned this Sep 16, 2017
@hailwood
Copy link

A possible suggestion before the package becomes too large due to "Please add support for X framework" requests.

Seperate the renderer out to it's own package.
then a user can pull in a renderer e.g. genealabs/laravel-messenger-bootstrap4 which will require genealabs/laravel-messenger.

This abstraction would also allow the community to add support for any number of rendering methods.

@mikebronner mikebronner modified the milestones: 1.1.0, 1.2.0 Sep 17, 2017
@mikebronner
Copy link
Owner Author

Thank you, that's a good point. I will delve into this down the road and explore this more. :)

@mikebronner mikebronner changed the title Add sweet alert for non-bootstrap users. Abstract rendering to separate packages. Sep 17, 2017
@mikebronner mikebronner removed this from the 1.2.0 milestone Sep 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants