error on count() or sum('column')

[jetwes]

Issue

*Alle queries with count() or sum('columnXYZ' return a "undefined index, operator" error.
Exapmle: $sale = SaleItem::whereIn('sku', $prod_array) ->whereBetween('created_at', [$start, $end]) ->count();
*

Environment

Laravel Version: 5.5.34
Laravel Model Caching Package Version: 0.2.21
PHP Version: 7.1.0

Stack Trace

*/home/vagrant/Projects/bvj-portal-55/vendor/genealabs/laravel-model-caching/src/CacheKey.php
 
                return $carry . '_orderBy_' . $order['column'] . '_' . $order['direction'];
            })
            ?: '';
    }
 
    protected function getQueryColumns(array $columns) : string
    {
        if ($columns === ['*'] || $columns === []) {
            return '';
        }
 
        return '_' . implode('_', $columns);
    }
 
    protected function getTypeClause($where) : string
    {
        $type =in_array($where['type'], ['In', 'Null', 'NotNull'])
            ? strtolower($where['type'])
            : strtolower($where['operator']);
 
        return str_replace(' ', '_', $type);
    }
 
    protected function getValuesClause(array $where = null) : string
    {
        return is_array(array_get($where, 'values'))
            ? '_' . implode('_', $where['values'])
            : '';
    }
 
    protected function getWhereClauses(array $wheres = []) : string
    {
        return $this->getWheres($wheres)
            ->reduce(function ($carry, $where) {
                $value = $this->getNestedClauses($where);
                $value .= $this->getColumnClauses($where);
                $value .= $this->getRawClauses($where);
                $value .= $this->getOtherClauses($where, $carry);
 
Arguments
"Undefined index: operator (View: /home/vagrant/Projects/bvj-portal-55/resources/views/start.blade.php)"*

[jetwes]

updated to php 7.1.14 without any change

[mikebronner]

Hi @jetwes , thank you for reporting this. I will look into this as soon as I get back to my office on Tuesday.

[jetwes]

The error seems not related to count() but to ->whereBetween
If i add 'between' to $type =in_array($where['type'], ['In', 'Null', 'NotNull','between']) ? strtolower($where['type']) : strtolower($where['operator']);
this particular error is gone

[mikebronner]

@jetwes Could you provide the stack track from laravel.log? Thanks :)

[mikebronner]

I have been able to replicate the problem and am now working on a fix 👍

[mikebronner]

Will take some time, I need to go through a few other things for this fix, won't be able to get to it today, hopefully tomorrow.

[jetwes]

thank you for the update and the effort on this great package

[mikebronner]

@jetwes Please check if release 0.2.23 fixed this issue for you. Let me know how it goes. :)

[jetwes]

yeah - it's looking good!

[jetwes]

Sorry - too early ;) Same error when whereNotIn is used - so "NotIn" has to be added to the array, too...

[mikebronner]

@jetwes Thanks! Will fix that ASAP. :)

[mikebronner]

@jetwes Should be fixed in 0.2.24 -- Let me know :)

[jetwes]

great - thanks