Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache key namespacing pattern #78

Closed
andrewmclagan opened this issue Feb 17, 2018 · 2 comments
Closed

Cache key namespacing pattern #78

andrewmclagan opened this issue Feb 17, 2018 · 2 comments
Assignees

Comments

@andrewmclagan
Copy link

Issue

They cache keys and naming scheme is quite hard for developers to read and does not follow any recognisable pattern e.g. 'genealabslaravelmodelcachingtestsfixturesbook'

Solution

It would be more readable and best practice to follow a cache key namespacing architecture as those recommended by Redis.

e.g.

genealabs:model-caching:test-fixtures:book

@mikebronner
Copy link
Owner

Actually, the cache keys are hashed versions of the key, but the tags aren't. Ian thinking of changing the way the keys are generated anyway.

@mikebronner mikebronner self-assigned this Feb 17, 2018
@mikebronner
Copy link
Owner

@andrewmclagan This is now implemented in version 0.3.31. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants