"peak_start is not defined" error

[RLesser]

Started getting this error for these inputs:
First Time: Yes
Previous Pattern: Unknown
Sunday: 100
Week Prices: 43, 38, 100, 84, 150

[joelft]

I am also getting this error. In my case it's when loading the page with URL parameters like this https://turnipprophet.io/index.html?prices=100.58.53.94.140.164.0.0.0.0.0.0.0

[theRTC204]

Almost certainly related to the refactor that was merged shortly before these reports.

Investigating...

[ChiefMilesEdgeworth]

It could be here:

ac-nh-turnip-prices/js/predictions.js

Lines 165 to 182 in 8f49882

	function generate_peak_price(
	given_prices, predicted_prices, start, rate_min, rate_max) {
	rate_min *= RATE_MULTIPLIER;
	rate_max *= RATE_MULTIPLIER;
	const buy_price = given_prices[0];
	// Main spike 1
	min_pred = get_price(rate_min, buy_price) - 1;
	max_pred = get_price(rate_max, buy_price) - 1;
	if (!isNaN(given_prices[start])) {
	if (given_prices[start] < min_pred - FUDGE_FACTOR || given_prices[peak_start + 2] > max_pred + FUDGE_FACTOR) {
	// Given price is out of predicted range, so this is the wrong pattern
	return false;
	}
	min_pred = given_prices[start];
	max_pred = given_prices[start];
	}

The peak_start variable is used in an if statement without being declared for the function on line 176.

[peter50216]

Well that's what happen when you partially revert a PR... 🤦
All my fault, I didn't check the intermediate commit that carefully.

[mikebryant]

Sorry about that!