Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If ctrl-clicked, MyQOnly's review links are opened in Container of currently-focused tab #18

Open
dholbert opened this issue Oct 24, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@dholbert
Copy link

STR:

  1. Open a Container Tab (by e.g. long-pressing the "+" icon on your tabs toolbar, if you're using Nightly, and picking "Banking")
  2. Be sure that container tab is your currently active tab.
  3. Click the MyQOnly icon on your toolbar.
  4. Ctrl-click (Cmd-click on Mac) one of the links for your pending reviews, assuming you've got some.
    (Or middle-mousebutton-click, which has the same semantics on Linux at least.)

ACTUAL RESULTS:
The review page opens in a new tab in the background, and that tab is in the same container as your currently active tab, e.g. "Banking", which you can tell because:

  • It's got the colorful underline to indicate this
  • it doesn't have your login state (assuming your auth cookie is in your default container)

EXPECTED RESULTS:
New tab should be in the default container.

Note that I get expected results if I simply left-click the link (no keyboard modifiers), and I also get expected results if I shift-click the link (which opens a new window, whose sole tab is in the default container). Only ctrl-click/middle-mousebutton-click have this problem.

@mikeconley mikeconley added the bug Something isn't working label Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants