Changing file in the pdf component.

[anedisi]

This part in componentWillReceiveProps makes it so that that i can change the pdf if i change the file prop, the problem is that i have to use documentInitParameters because without that i cannot pass other parameters to getDocument. But if i change the url in documentInitParameters the component will not rerender because its allways asking it file,content or binaryContent have been changed and if not it will not trigger loadPDFDocument even with

(newDocInit && docInit && newDocInit.url !== docInit.url)))

because newSource and oldSource are the same.

const newDocInit = newProps.documentInitParameters;
const docInit = this.props.documentInitParameters;

// Only reload if the most significant source has changed!
let newSource = newProps.file;
let oldSource = newSource ? this.props.file : null;
newSource = newSource || newProps.binaryContent;
oldSource = newSource && !oldSource ? this.props.binaryContent : oldSource;
newSource = newSource || newProps.content;
oldSource = newSource && !oldSource ? this.props.content : oldSource;

if (newSource && newSource !== oldSource &&
  ((newProps.file && newProps.file !== this.props.file) ||
  (newProps.content && newProps.content !== this.props.content) ||
  (newDocInit && newDocInit !== docInit) ||
  (newDocInit && docInit && newDocInit.url !== docInit.url))) {
  this.loadPDFDocument(newProps);
}

[ThomasVuillaume]

Same problem here, we sould correct this. I'll propose a pull request

[ThomasVuillaume]

just created #33

Edit: Ok, was too quick on this one. Makes it loop forever rendering the same pdf. Going to check and fix this.

[ThomasVuillaume]

Ok I got this right now, tested and works fine !

Ready to merge

[mikecousins]

Thanks @ThomasVuillaume, I just merged it.