Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'worker-loader' requires 'webpack' as peerDependency #46

Closed
MichaelDeBoey opened this issue Dec 7, 2017 · 2 comments
Closed

'worker-loader' requires 'webpack' as peerDependency #46

MichaelDeBoey opened this issue Dec 7, 2017 · 2 comments

Comments

@MichaelDeBoey
Copy link
Contributor

When I install react-pdf-js in a clean repo, I get the following warnings:

npm WARN react-pdf-js@3.0.2 requires a peer of react@>=15 but none is installed. You must install peer dependencies yourself.
npm WARN react-pdf-js@3.0.2 requires a peer of react-dom@>=15 but none is installed. You must install peer dependencies yourself.
npm WARN worker-loader@1.1.0 requires a peer of webpack@^2.0.0 || ^3.0.0 but none is installed. You must install peer dependencies yourself.

react& react-dom are marked as peerDependencies, but webpack isn't.
Please add webpack to the peerDependencies, since this is a peerDependency of worker-loader, which is a dependency of pdfjs-dist.

I've added a similar issue upstream, so pdfjs-dist will list webpack as a peerDependency (mozilla/pdf.js#9248).

@MichaelDeBoey
Copy link
Contributor Author

This is now patched by mozilla/pdf.js#9249 🙂

@mikecousins
Copy link
Owner

Nice, I'll try to get this updated then tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants