Issue within React Create App

[Darren-Ivey]

I have added this package to a React Create App, but get the following error (as well as a several warning):

"Uncaught TypeError: Invalid Version: semver.js:293 "

I updated both my npm and node, but the issue persisted. Is this a common issue and is there a solution?

Thanks in advance.

[kaizensoze]

Are you using gulp? Searching on the error in google shows several of the first results being related to gulp:

https://www.google.com/search?q=Uncaught+TypeError%3A+Invalid+Version%3A+semver.js%3A293&oq=Uncaught+TypeError%3A+Invalid+Version%3A+semver.js%3A293&aqs=chrome..69i57.132j0j7&sourceid=chrome&ie=UTF-8

[Darren-Ivey]

Thanks for a fast response. Unfortunately I am not using Gulp.

[kaizensoze]

Do you have a sample project I can take a look at to reproduce the issue?

[Darren-Ivey]

I have put a bare bones crate react app with the github demo in the App.js here: https://github.com/Darren-Ivey/React-GitHubApi-Test

[kaizensoze]

My best guess is an incompatibility with webpack. Unfortunately there isn't currently a fix.

[Darren-Ivey]

Ok, fair enough. Thank you for looking into the issue, it's much appreciated.

[gr2m]

@Darren-Ivey I made a few changes recently that should help with browserify compatibility. Could you give it another try by chance?

Also the next milestone is browser compatibility, if you are interested in progress I recommend to subscribe to this issue: #620

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gr2m]

It should work with latest @octokit/rest, please let me know if it doesn’t.

I working towards further browser improvements, like test setups and reduced bundle size. See https://github.com/octokit/rest.js/issues/620#issuecomment-362715478

[rsullivan00]

@gr2m Looks like the Octokit npm package isn't compiled to ES5, which create-react-app expects for dependencies.

yarn run v1.5.1
$ yarn run build
$ NODE_PATH=./src react-app-rewired build
Creating an optimized production build...
Failed to compile.

Failed to minify the code from this file:

 	./node_modules/@octokit/rest/lib/plugins/pagination/get-page-links.js:10:26

Read more here: http://bit.ly/2tRViJ9

error An unexpected error occurred: "Command failed.
Exit code: 1
Command: sh
Arguments: -c NODE_PATH=./src react-app-rewired build

[gr2m]

Could you please create a follow up issue on that? I try to avoid a build step right now, but plan to use the ES Modules syntax in future for better tree shaking / smaller bundle size, so that should fix it for good. But before that it would be great if you could have a look what syntax is breaking right now, if it's not too much we can just make the change directly

[rsullivan00]

Looks like that line uses an arrow function--I doubt it's worthwhile to manually convert ES6 syntax to ES5. I can work around this by forking and building to ES5 in the short term.

link.replace(/<([^>]*)>;\s*rel="([\w]*)"/g, (m, uri, type) => {

I'll create a separate issue to track the issue.