-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preload main feed data on startup #750
Comments
@mikedilger this needs your approval :) /cc @bu5hm4nn |
I don't think we should load the data immediately, I think the 'loading' screen @bu5hm4nn just did ( that you designed ) is sufficient. We could load local database events, but it's complexity and complexity that makes gossip harder and harder to maintain. |
Well we could load a local cache version of the feed and then update to the live later? |
Is it for a specific reason? Just to understand your pov.
Actually, if I access "offline" the feed is immediately available, so the db data is already used in this case. Showing it could be a solution, but you will have a refresh in some seconds and since the feed auto scrolls, you will loose the context. I would avoid that. It's not a critical point of course, just a nice touch. |
I can't reproduce. If I start in offline mode I see all the local notes just fine. I don't see any useless empty feed. |
When the user unlocks the private key or just skip the login, he faces an empty page with a (useless) "load more" button for some seconds:
Can we start fetching the data immediately when Gossip starts, at least if the user didn't select "Start in offline mode" in a previous session?
If that is not possibile, we can fallback with a better loading view
The text was updated successfully, but these errors were encountered: