-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About dependencies in package.json #82
Comments
I felt a little weird removing the dependencies entirely, but I added some to peer dependencies in the latest beta. Let me know if that helps you @ryouaki |
Thank you for your replay , yes it will help me and fix my problem. |
I saw your change, But I think move to peer dependencies is better。 If still keep in dependencies, I have a package need "commander" with version "1.0.0", and in po2json is version 2.18.0, when I run npm install --production, it will install 2.18.0 and 1.0.0 form my project. And will get risk for my project. |
If you are using both versions in your project, both will be installed. The risk would be install one only. You need to go ahead with one of both if you want to remove the redundancy: upgrade your commander-dependent code in your project in order to use 2.18.0 only or stop using po2json because does not meet your dependencies versions.
Sorry @mikeedwards, but I'm getting always the next warning message installing po2json:
This redundancy in the dependencies of the project doesn't have any sense. Are peer or normal dependencies? Please, consider remove |
Expected Behavior
What did you want to happen?
Actual Behavior
In package.json,have three dependencies:
Steps to Reproduce
When I use po2json on my project,it will install two dependencies which has two different version like "commander@2.20.0" and "commander@2.15.1", and will both build in my production Javascript files.
Additional Data
change to peerdependencies will fix this problem。
The text was updated successfully, but these errors were encountered: