Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to loosen the dependency on halo #2

Closed
Agnes-U opened this issue Nov 13, 2022 · 1 comment
Closed

Suggest to loosen the dependency on halo #2

Agnes-U opened this issue Nov 13, 2022 · 1 comment

Comments

@Agnes-U
Copy link

Agnes-U commented Nov 13, 2022

Hi, your project jfc(commit id: ceae86e) requires "halo==0.0.31" in its dependency. After analyzing the source code, we found that the following versions of halo can also be suitable, i.e., halo 0.0.30, since all functions that you directly (1 APIs: halo.halo.Halo.init) or indirectly (propagate to 8 halo's internal APIs and 6 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on halo from "halo==0.0.31" to "halo>=0.0.30,<=0.0.31". This will improve the applicability of jfc and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on halo?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

@mikeevmm
Copy link
Owner

jfc is not a library, it's a binary for end-use, in a sense. So, while doing something like you suggest could make sense for something to be integrated in other applications, in this case I would rather pin a version and controllingly upgrade the dependencies in a PATCH release (as has happened).

This being said, this message feels very automated (and almost certainly is, based on your activity profile), and hence borderline spam-like. If you're trying to kickstart/sell/pitch some service, this might not be the best way to go about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants