3.0.1 still breaks formatting and comments

[hassomehide]

From the release notes:

Keeps yaml comments and formatting, can specify yaml tags when updating. #19, #169, #107, #171, #245, #303

Unfortunately some issues are still present.

Formatting:

spec:
  ports:
    - name: http
      port: 80
      targetPort: 80

is formatted to:

spec:
  ports:
  - name: http
    port: 80
    targetPort: 80

Notice the whitespace difference before the array element.

Comments:

Even though comments are now preserved, they seem to be re-encoded in some other encoding than UTF-8 because I'm getting back ��� instead of the symbols that were originally present in the comments.

This is the yq command I'm using:

yq write -i -d1 test.yaml 'spec.template.spec.containers(name==test).image' test-value

[itsMichaelBates]

+1 same issue (and I'm using it for exactly the same purpose as @hassomehide - updating Kubernetes deployment container images 😅)

[mikefarah]

Do you have an example for the encoding issue?
The whitespace issue is a problem of the underlying parser, however you can set an indent of 4 and that will place the arrays indented of the map. Not sure why it behaves differently with and indent of 2 - but the yaml is still valid fwiw.

[mikefarah]

Appears to be a an issue in the underlying yaml parser (yaml.v3)

go-yaml/yaml#538
and
go-yaml/yaml#578

[mikefarah]

Indent bug: go-yaml/yaml#559