Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors reported by iptables during rule loading should cause task to fail #5

Closed
conorsch opened this issue Sep 28, 2016 · 0 comments
Closed

Comments

@conorsch
Copy link
Contributor

The iptables load task blithely ignores errors printed to stderr via iptables, for example:

$ sudo /etc/iptables.v4.generated
iptables v1.4.21: unknown option "--dstport"
Try `iptables -h' or 'iptables --help' for more information.
iptables v1.4.21: unknown option "--dstport"
Try `iptables -h' or 'iptables --help' for more information.

The mistake is a typo: --dstport isn't a valid option, and should instead be --dport. Iptables caught that error and reported it, but the misconfiguration didn't percolate up and cause the role execution to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant