Skip to content
This repository has been archived by the owner on May 3, 2023. It is now read-only.

androidx.core.util.pair isn't reversed #48

Closed
Dror-Bar opened this issue Aug 25, 2019 · 4 comments
Closed

androidx.core.util.pair isn't reversed #48

Dror-Bar opened this issue Aug 25, 2019 · 4 comments

Comments

@Dror-Bar
Copy link

Hey all, first of all let me say this is a really useful library, thanks a lot!

I was using this library for the reverse functionality with the -r flag. It worked as expected, however it missed one import which is androidx.core.util.pair, and I had to manually change it to android.support.v4.util.Pair. This should probably be implemented in master.

Thanks.

@Dror-Bar Dror-Bar changed the title androidx.core.util.pair isn't revered androidx.core.util.pair isn't reversed Aug 25, 2019
@mikehardy
Copy link
Owner

Strange, it's in the mapping https://github.com/mikehardy/jetifier/blob/master/mapping/androidx-class-mapping.csv#L1553

perhaps it is the capital letter vs not capital letter?

@mikehardy
Copy link
Owner

please give an example of a react-native module that exhibits the behavior so we can check

@Dror-Bar
Copy link
Author

It happened to me with react-native-view-shot.

However, my colleague just tried it and it worked for him.
I think it may have to do with me changing the code manually (I may have added a space).
So it's probably working on a clean module.
Closing.

@mikehardy
Copy link
Owner

whew! :-), thank you for double-checking - happy coding!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants