Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native macCatalyst #14

Open
elmcapp opened this issue Sep 2, 2022 · 7 comments
Open

React Native macCatalyst #14

elmcapp opened this issue Sep 2, 2022 · 7 comments

Comments

@elmcapp
Copy link

elmcapp commented Sep 2, 2022

First of all great work and I really appreciate all the hard work you and your team have put into this.

I like to know if there is a clean version of this script. I would like to run React Native as macCatalyst without the firebase? Also when I run the build I get error that firebase.h file is missing. Is this something I have to add manually. Last question are there any plans that this will be part of React Native main branch and included in their 0.70 or later release or will it be a separate project.

@mikehardy
Copy link
Owner

Thanks, it was quite the odyssey yes

There is no "clean" version, the repo is specifically "rnfbdemo", as such, it is clean for me and for the purpose of the repo 😆

It's open source though, fork and alter as much as you like - frequently I delete huge chunks of it in order to cleanly reproduce things for internal react-native folks, it's pretty easy to do

Also when I run the build I get error that firebase.h file is missing

This is not enough information to help (https://stackoverflow.com/help/how-to-ask) - I would need a lot more information about toolchains used etc. I run this pretty frequently and I don't have problems ?

are there any plans that this will be part of React Native main branch and included in their 0.70 or later release or will it be a separate project

In grammar terms "this" here in "are there any plans that this" is an ambiguous antecedent, I'm not sure what you mean by this. The addition of the macCatalyst flag in react-native (which should release with 0.70) covers most of the workarounds. You'll still need to alter your project to include macCatalyst as a possible target type, which implies adding entitlements and a development team, those can't be part of the template. All the workarounds will be there though, built in, if that's what you mean

facebook/react-native#34026
facebook/react-native@2fb6a33 (you can see it made the branch cut for 0.70-release as it's getting 0.70 tags)

@elmcapp
Copy link
Author

elmcapp commented Sep 9, 2022

With the new changes made to include macCatalyst I like to know if we can set window size like the width and height or disable window resizing. Seem like that's the missing puzzle. This can easy be done with swift but not sure how to do this with objective-c. Would like to know if you could point me to some example or provide example

@mikehardy
Copy link
Owner

Hey @elmcapp - sorry, no idea 😅 - there are enough "this thing does not even compile and run" things in the matrix of build possibilities that I haven't gotten to "subtle" things like "why's the window not a useful size?". It is a marathon not a sprint...

@elmcapp
Copy link
Author

elmcapp commented Sep 10, 2022

I was able to get macCatalyst running. I had to update my nodejs version to version 18 then I had to go to the pod file and change hermes_enabled => true, to false and then change mac_catalyst_enabled => false to true.

then pod install

Not sure why we have to disable Hermes.

@mikehardy
Copy link
Owner

🤔 in my testing on the last 0.70-rc I tested I did not have to disable hermes?

https://github.com/mikehardy/rnfbdemo/blob/rn70-hermes-use-frameworks/make-demo.sh

@elmcapp
Copy link
Author

elmcapp commented Sep 23, 2022

Are there any options for customizing the menu. I saw an example how to do in swift but currently React Native is in objective-c I was hoping we could edit the menu options

@mikehardy
Copy link
Owner

"the menu" - I'm sorry, what? This is a demonstration script for compiling things. It has no menus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants