Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Device node Sensor #215

Closed
FireWizard52 opened this issue Dec 22, 2021 · 5 comments
Closed

Google Device node Sensor #215

FireWizard52 opened this issue Dec 22, 2021 · 5 comments

Comments

@FireWizard52
Copy link
Contributor

FireWizard52 commented Dec 22, 2021

Hello all,

I continued to configure the Sensor node and I noticed a number of issues.
As an example I selected two sensors, Particulate Matter, PM10 and also PM25.
See the following test flow:

Screenshot_Google_Device_PM1

However, if I wanted to configure the Google Device node, I noted the following:

Screenshot_Google_Device_PM4

So, if you choose " Show trait" and select "Selected", you will see that there is nothing to select.

In the previous, I think, version it was possible:

Screenshot_Google_Device_PM5

A second thing I noted that also here 'If msg arrives on input, pass through to output:" does not give an output.
This has been reported before and I believe it has been picked up.

Regards

@ckhmer1
Copy link
Contributor

ckhmer1 commented Dec 22, 2021

I'll check this issue as soon as possible

@FireWizard52
Copy link
Contributor Author

FireWizard52 commented Dec 27, 2021

I have been able to experiment a little more and came across the following:

If I select as trait "Recommended" or "All", I'm able to configure the sensor (and possible also other devices). If I return later and if I select "Selected" I see my configuration and I can modify this, if I wanted.
This makes sense and I believe that this is also the intended use. You cannot select "Selected" before you have it configured.
I think this is the intended use and if you agree, we can close this issue.

However I suggest, that the option "Selected" should be omitted, until one has configured the trait. Or at least a clear explanation in its README file.

Regards

@ckhmer1
Copy link
Contributor

ckhmer1 commented Dec 27, 2021

For every device type there are some traits mandatory, you cannot unselected then. Selecting select the first time, the mandatory traits should be shown.
Sensors had no mandatory traits, it is why you don't see any traits of you select "selected"

@FireWizard52
Copy link
Contributor Author

Agree,
I had seen that the sensor node had no mandatory traits.
So your explanation is acceptable to me.

But if a less experieced user want to use this node it is maybe confusing and therefore I suggested to remove that option, if there are no mandatory traits.

Thanks for publicing the new version 0.2.0.
Something to try tomorrow.

@FireWizard52
Copy link
Contributor Author

I tested the sensor node and I noted that it works correctly and gives the Temperature in degrees Celsius as, e.g. TC: 9.8°C
Nice :)
However if I take other sensors such as PM10 or PM2.5, I don't see anything. I even cannot find the proper wording to ask for the values.
In the mean time I have transferred all the "old" and now deprecated nodes to the Google Device nodes and everything works as before.

I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants