From with non-plain From

[lejmr]

Hi,
I was playing a bit with redmine, which uses your mail library. So I filled an issue eventually (jfqd/redmine_helpdesk#36), because that third-party module does not work properly when I receive emails from Thunderbird/Outlook/... with header like this:

From: "Pavel Ryska [XXX s.r.o.]" pavel.ryska@XXX.cz
From: =?UTF-8?B?TWlsb8WhIEtvesOhaw==?= milos.kozak@XXX.cz

[jeremy]

Neither address parses since they're missing the <...> around the address:

>> mail = Mail.new('From: "Pavel Ryska [XXX s.r.o.]" pavel.ryska@XXX.cz')
=> #<Mail::Message:70328439583780, Multipart: false, Headers: <From: "Pavel Ryska [XXX s.r.o.]" pavel.ryska@XXX.cz>>
>> mail[:from].errors
=> [["From", "\"Pavel Ryska [XXX s.r.o.]\" pavel.ryska@XXX.cz", #<Mail::Field::ParseError: Mail::AddressList can not parse |"Pavel Ryska [XXX s.r.o.]" pavel.ryska@XXX.cz|
Reason was: Only able to parse up to "Pavel Ryska [XXX s.r.o.]" pavel.ryska@XXX.cz>]]
>> mail = Mail.new('From: "Pavel Ryska [XXX s.r.o.]" <pavel.ryska@XXX.cz>')
=> #<Mail::Message:70328432318680, Multipart: false, Headers: <From: "Pavel Ryska [XXX s.r.o.]" <pavel.ryska@XXX.cz>>>
>> mail[:from].errors
=> []

>> mail = Mail.new('From: =?UTF-8?B?TWlsb8WhIEtvesOhaw==?= milos.kozak@XXX.cz')
=> #<Mail::Message:70328449510020, Multipart: false, Headers: <From: =?UTF-8?B?TWlsb8WhIEtvesOhaw==?= milos.kozak@XXX.cz>>
>> mail[:from].errors
=> [["From", "=?UTF-8?B?TWlsb8WhIEtvesOhaw==?= milos.kozak@XXX.cz", #<Mail::Field::ParseError: Mail::AddressList can not parse |=?UTF-8?B?TWlsb8WhIEtvesOhaw==?= milos.kozak@XXX.cz|
Reason was: Only able to parse up to =?UTF-8?B?TWlsb8WhIEtvesOhaw==?= milos.kozak@XXX.cz>]]
>> mail = Mail.new('From: =?UTF-8?B?TWlsb8WhIEtvesOhaw==?= <milos.kozak@XXX.cz>')
=> #<Mail::Message:70328439933920, Multipart: false, Headers: <From: =?UTF-8?B?TWlsb8WhIEtvesOhaw==?= <milos.kozak@XXX.cz>>>
>> mail[:from].errors
=> []

[lejmr]

Ok, partly it is my fault I should have pointed it out.. but was removed by github..

Anyway, according to your previews (where you added <..>) it parses , i.e. this is not problem.. good to know. Thanks.