Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with Message editor and "styled" text in last line #44

Closed
mikelax opened this issue Jan 17, 2018 · 1 comment
Closed

Bug with Message editor and "styled" text in last line #44

mikelax opened this issue Jan 17, 2018 · 1 comment

Comments

@mikelax
Copy link
Owner

mikelax commented Jan 17, 2018

Overview

There is currently a bug in the editor when the last line of text uses one of the style icons. In this use case, if the cursor is after this style block (ie. the very end of the message) and you hit the return key, a newline is inserted before the style block instead of after it.

This happens on both the initial message create, and also if you go back and edit a message.

Here is a sample message that shows the error use case.

Here is the first line of text.
singingHere is a singing line of textsinging

This same issue also happens with the new Quote feature. It appears to be related to block level items.
This plugin appears like it might provide the fix we need. The plugin requires this plugin framework for draftjs. The framework might be a nice win anyway as there are some other plugins we may want to use such as emoji, image, linkify among others (these plugins will be in a separate Issue).

@mikelax
Copy link
Owner Author

mikelax commented Mar 20, 2018

draftjs specific editor.

@mikelax mikelax closed this as completed Mar 20, 2018
MVP automation moved this from To Do to Done Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
MVP
  
Done
Development

No branches or pull requests

2 participants