Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm test doesn't work #12

Open
azachar opened this issue May 13, 2017 · 2 comments
Open

npm test doesn't work #12

azachar opened this issue May 13, 2017 · 2 comments

Comments

@azachar
Copy link

azachar commented May 13, 2017

Hello,
I like your idea and want to fork it in order to provide an api that allows to add custom policies objects instead of just names, but running npm test is on your current code base is not working..

I am getting this results: (Also, I neeedd to use this form var agave = require('agave')('av'); in your test)

"fontSrc": [
           "data:"
           "fonts.googleapis.com"
           "fonts.gstatic.com"
      -    "themes.googleusercontent.com"
           "use.typekit.net"
         ]

         "frameSrc": [
           "js.stripe.com"
         "reportUri": "/csp-violation"
         "scriptSrc": [
           "'self'"
           "'unsafe-eval'"
      -    "analytics.twitter.com"
      -    "api.stripe.com"
           "cdn.mxpnl.com"
      -    "cdn.syndication.twimg.com"
           "js.stripe.com"
           "platform.twitter.com"
      -    "static.ads-twitter.com"
           "syndication.twitter.com"
           "use.typekit.net"
         ]
         "styleSrc": [

Please, could you please fix your code so I can provide my patches?

Thanks,
Andrej

@rousan
Copy link
Contributor

rousan commented Jul 13, 2018

I sent a PR against this issue.

@mikemaccana
Copy link
Owner

mikemaccana commented Jul 13, 2018

The test output you've provided doesn't look like anything to with agave:
image

Did you mean to file a bug with https://github.com/certsimple/csp-by-api instead?

Also all the tests pass there too (see the CI output in the README)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants