Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using some but not all defaults #34

Closed
jpoles1 opened this issue Jun 6, 2018 · 1 comment
Closed

Using some but not all defaults #34

jpoles1 opened this issue Jun 6, 2018 · 1 comment

Comments

@jpoles1
Copy link
Contributor

jpoles1 commented Jun 6, 2018

I noticed that when I tried to edit the defaults for minimum browser versions, but only wanted to change a single entry, I had to re-copy the entire version definition object over.

This is fine, if it's the intended behaviour, but we could also have it behave such that editing a single browser version will just overwrite that entry, while retaining the defaults for the other browsers. @mikemaccana any thoughts on if you'd like to make this change?

I believe the code in question lies on line 40 of index.js:

var browserSupport = options.browserSupport || DEFAULTS;
@mikemaccana
Copy link
Owner

Yep agreed that would be good. If you send a PR I'll merge it,.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants