Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving in Game Manager doesn't save until Game Manager window is closed #274

Closed
redactedscribe opened this issue Jul 14, 2022 · 1 comment
Assignees
Milestone

Comments

@redactedscribe
Copy link

Ideally, pressing Save would immediately write to the "gbm.s3db" file instead of waiting to write until the Game Manager window closes. Currently, it's possible to Save, kill the GBM process, re-run GBM and find that your changes were not saved.

Maybe there's a good reason why it's built like this? If so, perhaps Save should be renamed something like "Save on close"? Or, simply "Update" and perhaps add some text to the title bar or footer to say "Saves on close"?

As it stands, after pressing Save, there is no indication that the changes have not yet been written to the disk. For example, an asterisk somewhere, or italicised text on edited games in the list would help indicate uncommitted data.

Thanks.

GBM 1.3.1
Windows 11

@MikeMaximus MikeMaximus self-assigned this Jul 14, 2022
@MikeMaximus MikeMaximus added this to the 1.3.2 milestone Jul 14, 2022
@MikeMaximus
Copy link
Owner

I had already planned to fix this in 1.3.2, data will no longer be lost if the process ends before the Game Manager is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants