Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing bower.json #42

Closed
devantoine opened this issue Jul 31, 2014 · 8 comments
Closed

Add missing bower.json #42

devantoine opened this issue Jul 31, 2014 · 8 comments

Comments

@devantoine
Copy link

Adding the missing bower.json would be very nice to work with bower. It can download the project but it's not able to know which file to include, which is the exact purpose of the "main" property of the bower.json.

For more infos on how to do it, refer to the following issue: CreateJS/SoundJS#76

@MikeMcl
Copy link
Owner

MikeMcl commented Jul 31, 2014

I am reluctant to include more than one package metadata file. I don't want to have to add and maintain a package.json, bower.json and component.json etc. for my repos. It is a shame that bower does not fall back to the package.json 'main' property, but I don't want to get into all that...

@MikeMcl MikeMcl closed this as completed Aug 2, 2014
@metaman
Copy link

metaman commented Oct 13, 2014

Shame. We could have done with one as well. Obviously we could fork and add it but keeping the fork in sync is not ideal for us.

@MikeMcl
Copy link
Owner

MikeMcl commented Oct 13, 2014

The library is registered with bower and if a user just wants to install the main file (should that be bignumber.js or bignumber.min.js?) they can just do e.g.

bower install --save https://raw.githubusercontent.com/MikeMcl/bignumber.js/master/bignumber.min.js

@metaman
Copy link

metaman commented Oct 13, 2014

Thanks for the reply Mike! Unfortunately the issue is that we have custom dependency/build scripts that reply on our third party libraries having bower.json files :(

Should I get time (?) I would like to investigate changing this (i'm fairly new to the project). Personally I don't want a hard dependency on bower (useful that it is).

@nicolaes
Copy link

Had the same problem with bower.json's "main" property. Our scripts rely on that property to build the project - similar with what @metaman described.
Unfortunately we had to rely on big.js but the development is hindered due to it's reduced feature set.
Would love to see an update on this.

@MikeMcl
Copy link
Owner

MikeMcl commented Mar 30, 2015

@nicolaes Okay, I'll add a bower.json tomorrow.
Do you think the "main" file should be bignumber.js or bignumber.min.js?

@nicolaes
Copy link

Thanks @MikeMcl .
As bower automatic dependencies are almost always used with build scripts that include minification I suggest going with "main": "bignumber.js" - as you did in the big.js library :)
If there is need I can also lend a hand with the development around, by the way.

@MikeMcl
Copy link
Owner

MikeMcl commented Mar 31, 2015

bower.json added in v2.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants