reorg: Removed unnecessary logging_handler-dependency

MikeMitterer · Mar 26, 2018 · ba2b3fd · ba2b3fd
1 parent d31e210
commit ba2b3fd
Show file tree

Hide file tree

Showing 34 changed files with 35 additions and 59 deletions.
diff --git a/test/unit/config.dart b/test/unit/config.dart
@@ -20,8 +20,6 @@
 library mdl.test.unit.config;
 
 import 'dart:async';
-import 'package:logging/logging.dart';
-import 'package:logging_handlers/logging_handlers_shared.dart';
 import "package:mdl/mdl.dart";
 
 Future prepareMdlTest(Future additionalRegistration()) async {
@@ -30,12 +28,3 @@ Future prepareMdlTest(Future additionalRegistration()) async {
     await componentHandler().run();
 }
 
-void configLogging({final Level defaultLogLevel: Level.OFF }) {
-    //hierarchicalLoggingEnabled = false; // set this to true - its part of Logging SDK
-
-    // now control the logging.
-    // Turn off all logging first
-    Logger.root.level = defaultLogLevel;
-    Logger.root.onRecord.listen(new LogPrintHandler());
-}
-
diff --git a/test/unit/core/MdlComponent_test.dart b/test/unit/core/MdlComponent_test.dart
@@ -9,7 +9,7 @@ import 'package:dryice/dryice.dart' as di;
 import 'package:mdl/mdl.dart';
 import 'package:mdl/mdlmock.dart' as mdlmock;
 
-//import 'package:logging/logging.dart';
+import "package:console_log_handler/console_log_handler.dart";
 
 import '../config.dart';
 

diff --git a/test/unit/core/utils_test.dart b/test/unit/core/utils_test.dart
@@ -25,6 +25,8 @@ import 'dart:html' as dom;
 import "package:mdl/mdl.dart";
 import 'package:dryice/dryice.dart' as di;
 
+//import "package:console_log_handler/console_log_handler.dart";
+
 import '../config.dart';
 
 class MdlTestModule extends di.Module {
@@ -36,7 +38,7 @@ class MdlTestModule extends di.Module {
 
 main() {
     // final Logger _logger = new Logger("test.CoreUtils");
-    configLogging();
+    // configLogging();
 
     final dom.DivElement div = new dom.DivElement();
 

diff --git a/test/unit/directive/components/Translate_test.dart b/test/unit/directive/components/Translate_test.dart
@@ -11,8 +11,7 @@ import '../../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Formatter.Button");
-
-    configLogging();
+    // configLogging();
 
     final DomRenderer renderer = new DomRenderer();
     final dom.DivElement parent = new dom.DivElement();

diff --git a/test/unit/flux/ActionBus_test.dart b/test/unit/flux/ActionBus_test.dart
@@ -37,7 +37,7 @@ class TestSignal extends Action {
 
 main() {
     // final Logger _logger = new Logger("test.ActionBus");
-    configLogging();
+    // configLogging();
 
     group('ActionBus', () {
 

diff --git a/test/unit/flux/Dispatcher_test.dart b/test/unit/flux/Dispatcher_test.dart
@@ -57,7 +57,7 @@ class MyComponent {
 
 main() {
     // final Logger _logger = new Logger("test.Dispatcher");
-    configLogging();
+    // configLogging();
 
     group('Dispatcher', () {
         final ActionBus actionbus = new ActionBus();

diff --git a/test/unit/flux/Emitter_test.dart b/test/unit/flux/Emitter_test.dart
@@ -16,8 +16,7 @@ class MyEmitter extends Emitter {
 
 main() async {
     // final Logger _logger = new Logger("test.Emitter");
-
-    configLogging();
+    // configLogging();
 
     final MyEmitter emitter = new MyEmitter();
 

diff --git a/test/unit/form/form_test.dart b/test/unit/form/form_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() {
     // final Logger _logger = new Logger("test.Form");
-    configLogging();
+    // configLogging();
 
     final dom.FormElement form = new dom.FormElement();
 

diff --git a/test/unit/formatter/Badge_test.dart b/test/unit/formatter/Badge_test.dart
@@ -12,7 +12,7 @@ import '../config.dart';
 main() async {
     // final Logger _logger = new Logger("test.Formatter.Badge");
 
-    configLogging();
+    // configLogging();
 
     final DomRenderer renderer = new DomRenderer();
     final dom.DivElement parent = new dom.DivElement();

diff --git a/test/unit/formatter/Button_test.dart b/test/unit/formatter/Button_test.dart
@@ -12,7 +12,7 @@ import '../config.dart';
 main() async {
     // final Logger _logger = new Logger("test.Formatter.Button");
 
-    configLogging();
+    // configLogging();
 
     final DomRenderer renderer = new DomRenderer();
     final dom.DivElement parent = new dom.DivElement();

diff --git a/test/unit/formatter/Checkbox_test.dart b/test/unit/formatter/Checkbox_test.dart
@@ -13,7 +13,7 @@ import '../config.dart';
 main() async {
     // final Logger _logger = new Logger("test.Formatter.Checkbox");
 
-    configLogging();
+    // configLogging();
 
     final DomRenderer renderer = new DomRenderer();
     final dom.DivElement parent = new dom.DivElement();

diff --git a/test/unit/formatter/Labelfield_test.dart b/test/unit/formatter/Labelfield_test.dart
@@ -12,7 +12,7 @@ import '../config.dart';
 main() async {
     // final Logger _logger = new Logger("test.Formatter.LabelField");
 
-    configLogging();
+    // configLogging();
 
     final DomRenderer renderer = new DomRenderer();
     final dom.DivElement parent = new dom.DivElement();

diff --git a/test/unit/formatter/Radio_test.dart b/test/unit/formatter/Radio_test.dart
@@ -12,7 +12,7 @@ import '../config.dart';
 main() async {
     // final Logger _logger = new Logger("test.Formatter.Checkbox");
 
-    configLogging();
+    // configLogging();
 
     final DomRenderer renderer = new DomRenderer();
     final dom.DivElement parent = new dom.DivElement();

diff --git a/test/unit/formatter/Switch_test.dart b/test/unit/formatter/Switch_test.dart
@@ -12,7 +12,7 @@ import '../config.dart';
 main() async {
     // final Logger _logger = new Logger("test.Formatter.Switch");
 
-    configLogging();
+    // configLogging();
 
     final DomRenderer renderer = new DomRenderer();
     final dom.DivElement parent = new dom.DivElement();

diff --git a/test/unit/formatter/Textfield_test.dart b/test/unit/formatter/Textfield_test.dart
@@ -12,7 +12,7 @@ import '../config.dart';
 main() async {
     // final Logger _logger = new Logger("test.Formatter.Textfield");
 
-    configLogging();
+    // configLogging();
 
     final DomRenderer renderer = new DomRenderer();
     final dom.DivElement parent = new dom.DivElement();

diff --git a/test/unit/mock/Mock_test.dart b/test/unit/mock/Mock_test.dart
@@ -54,7 +54,7 @@ class MockModule2 extends di.Module {
 main() async {
     // final Logger _logger = new Logger("test.Mock");
 
-    configLogging();
+    // configLogging();
 
     group('Injection', () {
         setUp(() {

diff --git a/test/unit/observable/ObservableProperty_test.dart b/test/unit/observable/ObservableProperty_test.dart
@@ -11,7 +11,7 @@ import '../config.dart';
 main() async {
     // final Logger _logger = new Logger("test.ObservableProperty");
 
-    configLogging();
+    // configLogging();
     //await saveDefaultCredentials();
 
 

diff --git a/test/unit/template/TemplateRenderer_test.dart b/test/unit/template/TemplateRenderer_test.dart
@@ -13,7 +13,7 @@ import 'package:mdl/mdlmock.dart' as mdlmock;
 
 import '../config.dart';
 
-@MdlComponentModel
+@Component
 class TestComponent extends MdlTemplateComponent {
     static const String WIDGET_SELECTOR = "test-component";
 
@@ -59,8 +59,8 @@ void registerTestComponent() {
 
 main() async {
     //final Logger _logger = new Logger("test.TemplateRenderer");
+    // configLogging();
 
-    configLogging();
     final DomRenderer renderer = new DomRenderer();
 
     group('TemplateRenderer', () {

diff --git a/test/unit/utils/observables_test.dart b/test/unit/utils/observables_test.dart
@@ -23,8 +23,7 @@ import 'package:test/test.dart';
 import "package:mdl/mdl.dart";
 import "package:mdl/mdlobservable.dart";
 import 'package:logging/logging.dart';
-
-import '../config.dart';
+import 'package:console_log_handler/console_log_handler.dart';
 
 main() {
     final Logger _logger = new Logger("mdl.unit.test.Observables");

diff --git a/test/unit/utils/utils_test.dart b/test/unit/utils/utils_test.dart
@@ -23,11 +23,9 @@ import 'package:test/test.dart';
 
 import "package:mdl/mdlutils.dart";
 
-import '../config.dart';
-
 main() {
     // final Logger _logger = new Logger("test.DataAttribute");
-    configLogging();
+    // configLogging();
 
     group('DataAttribute', () {
         setUp(() { });

diff --git a/test/visual/components/accordion_test.dart b/test/visual/components/accordion_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Accordion");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/components/button_test.dart b/test/visual/components/button_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Button");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/components/checkbox_test.dart b/test/visual/components/checkbox_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Checkbox");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/components/data-table_test.dart b/test/visual/components/data-table_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.DataTable");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/components/icon_toggle_test.dart b/test/visual/components/icon_toggle_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.IconToggle");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/components/labelfield_test.dart b/test/visual/components/labelfield_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Labelfield");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/components/layout_test.dart b/test/visual/components/layout_test.dart
@@ -28,7 +28,7 @@ import 'package:mdl/mdl.dart';
 import '../config.dart';
 
 main() async {
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/components/menu_test.dart b/test/visual/components/menu_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Menu");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/components/progress_test.dart b/test/visual/components/progress_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Progress");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/components/radio_test.dart b/test/visual/components/radio_test.dart
@@ -29,7 +29,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Radio");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/config.dart b/test/visual/config.dart
@@ -23,7 +23,6 @@ import 'dart:async';
 
 import 'package:mdl/mdl.dart';
 import 'package:logging/logging.dart';
-import 'package:logging_handlers/logging_handlers_shared.dart';
 
 /*
  * Two ways to run these tests
@@ -43,15 +42,6 @@ import 'package:logging_handlers/logging_handlers_shared.dart';
  *      pub run test -p content-shell test/visual/test.dart
  */
 
-void configLogging() {
-    //hierarchicalLoggingEnabled = false; // set this to true - its part of Logging SDK
-
-    // now control the logging.
-    // Turn off all logging first
-    Logger.root.level = Level.INFO;
-    Logger.root.onRecord.listen(new LogPrintHandler());
-}
-
 Future initComponents() async {
     final Logger _logger = new Logger('mdl.test.visual.config.initComponents');
 

diff --git a/test/visual/core/componenthandler_test.dart b/test/visual/core/componenthandler_test.dart
@@ -28,7 +28,7 @@ import '../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Progress");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/core/parent_test.dart b/test/visual/core/parent_test.dart
@@ -30,7 +30,7 @@ import '../config.dart';
 /// Search next MDL-Parent in MDL-Component-Tree
 main() async {
     // final Logger _logger = new Logger("test.Parent");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();

diff --git a/test/visual/template/components/repeat_test.dart b/test/visual/template/components/repeat_test.dart
@@ -29,7 +29,7 @@ import '../../config.dart';
 
 main() async {
     // final Logger _logger = new Logger("test.Repeat");
-    configLogging();
+    // configLogging();
 
     registerMdl();
     await initComponents();