Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table support #2

Closed
benjaminmaccini opened this issue Nov 12, 2020 · 3 comments
Closed

Add table support #2

benjaminmaccini opened this issue Nov 12, 2020 · 3 comments

Comments

@benjaminmaccini
Copy link

Description

Render markdown tables. Should be able to add something along these lines and have it render.

| asdf | fdas |
| --- | --- |
| 123 | 321 |

Could be nice to have some nice CSS for the tables too.

Minimal Fix

Change

python -m markdown -x smarty resume.md >> $@

to

python -m markdown -x smarty -x tables resume.md >> $@

Reference

@mikepqr
Copy link
Owner

mikepqr commented Dec 2, 2020

Thanks for the suggestion! That change is of course easy to make, but I'm wondering what the use case is? Unless you're (mis?)using tables for layout (in which case markdown is the wrong thing altogether), I don't see a reason to include a table in a standard resume.

And with that in mind it's difficult to know what kind of default CSS to provide. Could you give some examples of resumes with tables, or at least what you'd do with tables if you could use them?

@benjaminmaccini
Copy link
Author

I used it for layout, specifically displaying denser sections (e.g. skills or proficiency of languages and corresponding packages). In your opinion, what would be the right way to manage layout? HTML? Also, good point, I can't find any example resumes with a table... should probably change mine then lol 🤔.

Feel free to close out the issue, I don't believe it's broadly applicable.

@mikepqr
Copy link
Owner

mikepqr commented Dec 4, 2020

In general one should manage layout of HTML with CSS, not with tables.

In this particular case, if you have a list of skills then it should be a bulleted list in the markdown and then style the corresponding ul and li elements in CSS to make it the list more compact, make the items span-level, etc., etc.

The challenge with resume.md is you don't have much control over the HTML (you can't even apply classes), so it's tricky to do anything too clever with CSS. But having seen a lot of clever resumes, I think that's a feature not a bug! :-)

@mikepqr mikepqr closed this as completed Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants