Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-26: Add a option to generate Static Typed GDScript tests #26

Closed
afonsolage opened this issue Mar 27, 2021 · 1 comment · Fixed by #34
Closed

GD-26: Add a option to generate Static Typed GDScript tests #26

afonsolage opened this issue Mar 27, 2021 · 1 comment · Fixed by #34
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@afonsolage
Copy link

Is your feature request related to a problem? Please describe.
When a new test is generated, it generates the default dynamic GDScript syntax, since I use Static Typed GDScript, I need to convert it, which isn't a big deal, I just need to add -> void: at the end of the function.

Since the number of Static Typed GDScript is increasing, due the Godot 4.0 performance improvements, it would be a good idea to have an option to generate the code using the Static Tyuped GDScript

Describe the solution you'd like
Add a configuration option to generated new code using Static Typed GDScript syntax.

Describe alternatives you've considered
Just keep adding it manually. It isn't a big deal also, just a minor QoL

Additional context
N/A.

@MikeSchulze
Copy link
Owner

For clarification you mean 'create Test' should create a typed test case right?

like this

# GdUnit generated TestSuite
class_name ExampleTest
extends GdUnitTestSuite

# TestSuite generated from
const __source = 'res://foo/src/core/Example.gd'

func foo() -> void:
	# remove this line and complete your test
	assert_not_yet_implemented()

@MikeSchulze MikeSchulze self-assigned this Mar 27, 2021
@MikeSchulze MikeSchulze added this to To Do in GdUnit3 via automation Mar 27, 2021
@MikeSchulze MikeSchulze added the enhancement New feature or request label Mar 27, 2021
@MikeSchulze MikeSchulze added this to the beta v0.9.1 milestone Mar 27, 2021
@MikeSchulze MikeSchulze moved this from To Do to In progress in GdUnit3 Mar 28, 2021
@MikeSchulze MikeSchulze linked a pull request Mar 28, 2021 that will close this issue
GdUnit3 automation moved this from In progress to Done Mar 28, 2021
@MikeSchulze MikeSchulze changed the title Add a option to generate Static Typed GDScript tests GD-26: Add a option to generate Static Typed GDScript tests Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
GdUnit3
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants