Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GD-66: GdUnitInspector: Invalid state for failing tests by test timeout #66

Closed
MikeSchulze opened this issue May 23, 2021 · 1 comment · Fixed by #68
Closed

GD-66: GdUnitInspector: Invalid state for failing tests by test timeout #66

MikeSchulze opened this issue May 23, 2021 · 1 comment · Fixed by #68
Assignees
@MikeSchulze
Labels
bug Something isn't working major
Projects
GdUnit3
Milestone
v0.9.4-rc

Comments

@MikeSchulze
Copy link
Owner

MikeSchulze commented May 23, 2021 •
edited
Loading

The used Godot version:
Godot 3.3

OS including version:
Windows 10 / MacOs

Describe the bug
Playing around with test timeouts and set the timeout to 4s on project settings.
Some of the test now failing by a timeout error as expecting.
But the GdUnitInspector shows incorrect states.
image
The errors also not counted in the bar on top.

Steps to Reproduce
Go to project settings and set test timeout to 4s.
image

  • run tests
  • check the inspector state
@MikeSchulze MikeSchulze added the bug Something isn't working label May 23, 2021
@MikeSchulze MikeSchulze added this to the v0.9.4-rc milestone May 23, 2021
@MikeSchulze MikeSchulze self-assigned this May 23, 2021
@MikeSchulze MikeSchulze added this to To Do in GdUnit3 via automation May 23, 2021
@MikeSchulze MikeSchulze changed the title GdUnitInspector: Invalid state for failing tests by test timeout GD-66: GdUnitInspector: Invalid state for failing tests by test timeout May 23, 2021
@MikeSchulze MikeSchulze moved this from To Do to In progress in GdUnit3 May 23, 2021
@MikeSchulze MikeSchulze linked a pull request May 23, 2021 that will close this issue
GD-66: Fixed error reporting on inspector and command line tool #68
Merged
GdUnit3 automation moved this from In progress to Done May 23, 2021
@MikeSchulze
Copy link
Owner Author

The inspector now shows correct state
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MikeSchulze MikeSchulze

Labels
bug Something isn't working major
Projects
No open projects
GdUnit3
  
Done
Milestone
v0.9.4-rc
Development

Successfully merging a pull request may close this issue.

GD-66: Fixed error reporting on inspector and command line tool MikeSchulze/gdUnit3
1 participant
@MikeSchulze