Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GD-90: Some notes on tag gdUnit3-0.9.5-rc #90

Closed
4 tasks
clemens-tolboom opened this issue Jun 13, 2021 · 3 comments · Fixed by #92
Closed
4 tasks

GD-90: Some notes on tag gdUnit3-0.9.5-rc #90

clemens-tolboom opened this issue Jun 13, 2021 · 3 comments · Fixed by #92
Assignees
Labels
refactoring Mark to refactoring a implementation
Projects
Milestone

Comments

@clemens-tolboom
Copy link
Contributor

clemens-tolboom commented Jun 13, 2021

The used Godot version:

Godot-3.3.2

OS including version:

Mac OS Big Sure 11.4

Describe the bug

  • This version is not available in the AssetLib
  • The zip contains a directory examples, can we rename that into gdUnit3-examples?
  • Why is there a (extra) plugin directory GdCommons which is confusing
  • Dropping the zip into existing project generates error. See below

I run using a shell script and the terminal shows this error

/Applications/Godot_v3.3.2-stable_osx.universal.app/Contents/MacOS/Godot --editor
...
SCRIPT ERROR: GDScript::reload: Parse Error: The identifier "TimeUnit" isn't declared in the current scope.
   At: res://addons/GdCommons/DateTime/src/LocalTime.gd:48.
ERROR: reload: Method failed. Returning: ERR_PARSE_ERROR
   At: modules/gdscript/gdscript.cpp:583.

Steps to Reproduce

  1. Download ZIP version from github
  2. Unzip
  3. Drop all files into an existing project
  4. Start Godot from command-line
  5. Check the script output

Minimal reproduction project:

@clemens-tolboom clemens-tolboom added the bug Something isn't working label Jun 13, 2021
@clemens-tolboom
Copy link
Contributor Author

Note this is my brain dump noting stressores ;-)

@MikeSchulze
Copy link
Owner

Thanks for reporting.

  • This version is not available in the AssetLib

Yes it is not published yet

  • The zip contains a directory examples, can we rename that into gdUnit3-examples?

Yes, this is a good idea.

  • Why is there a (extra) plugin directory GdCommons which is confusing

This is a left over and will be moved next into the plugin.

  • Can we move this into gdUnit3 directory?

yes

  • Dropping the zip into existing project generates error. See below

Uh thats bad, i have to verify.

For the README.md, yes it makes sense to have install instructions and short example here

@MikeSchulze MikeSchulze added this to To Do in GdUnit3 via automation Jun 13, 2021
@MikeSchulze MikeSchulze changed the title Some notes on tag gdUnit3-0.9.5-rc GD-90: Some notes on tag gdUnit3-0.9.5-rc Jun 13, 2021
@MikeSchulze MikeSchulze moved this from To Do to In progress in GdUnit3 Jun 13, 2021
@MikeSchulze MikeSchulze linked a pull request Jun 13, 2021 that will close this issue
GdUnit3 automation moved this from In progress to Done Jun 13, 2021
@MikeSchulze MikeSchulze added refactoring Mark to refactoring a implementation and removed bug Something isn't working labels Jun 13, 2021
@MikeSchulze MikeSchulze added this to the v0.9.6-rc milestone Jun 13, 2021
@MikeSchulze
Copy link
Owner

GdUnit3 v0.9.6-rc should be available in AssetLib in some minutes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Mark to refactoring a implementation
Projects
No open projects
GdUnit3
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants