Add Movie Information Pop-up to Fullscreen Wall #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice idea. Looks cool! |
MikeSiLVO
added a commit
that referenced
this pull request
Jan 13, 2016
Add Movie Information Pop-up to Fullscreen Wall
MikeSiLVO
added a commit
that referenced
this pull request
Jan 13, 2016
Add Movie Information Pop-up to Fullscreen Wall
MikeSiLVO
added a commit
that referenced
this pull request
Jan 13, 2016
Add Movie Information Pop-up to Fullscreen Wall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mike,
I thought I'd take another shot at preparing a PR. I added a pop-up on focus to Fullscreen Wall and liked how it looked, so I thought I'd make an attempt to share it with others.
The code should be properly labelled, indented and easy to work with and understand. I'm not much for animations, so the animation of the pop-up could be improved. And I think it would be best to create a visibility condition to hide the Context Menu when the pop-up is active.
The pop-up is designed to match the skin and works as shown below: