Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

myflix view - logo vertical alignment change #160

Merged
merged 1 commit into from Aug 26, 2022

Conversation

monisriz
Copy link
Contributor

Reason for the change:

The current bottom align for "aligny" works well for logos on fanart.tv since they have a strict rule about logos being 800px by 310px.

However, TMDB also introduced logos recently. TMDB doesn't have a size restriction. TMDB also does not care about any aspect ratio. It trims any transparent part around the logo and reduces the dimensions of the uploaded logo to a minimum.
Some logos are just simply text in one line and TMDB reduces them to a thin strip of text with no padding around the text at all. When aligny=bottom is used these logos sometimes sit just barely on top of the info section and this leaves a huge space above the logo empty.

Using aligny="center" nicely puts the logo in the center (vertically) leaving some space at the bottom and the top if needed.

For example, logos from TMDB and Fanart.tv for "Dynasties":
https://www.themoviedb.org/tv/82953-dynasties/images/logos
https://fanart.tv/series/352054/dynasties-2019/

See screenshots below for clarity - used logos from TMDB (since it's the default TV show scrapper for Kodi now):

Before Change:
image

After Change:

image

@monisriz monisriz changed the title myflix logo vertical alignment change myflix view - logo vertical alignment change Aug 17, 2022
@MikeSiLVO
Copy link
Owner

Thanks :)

@MikeSiLVO MikeSiLVO merged commit 18374c3 into MikeSiLVO:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants