myflix view - logo vertical alignment change #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for the change:
The current bottom align for "aligny" works well for logos on fanart.tv since they have a strict rule about logos being 800px by 310px.
However, TMDB also introduced logos recently. TMDB doesn't have a size restriction. TMDB also does not care about any aspect ratio. It trims any transparent part around the logo and reduces the dimensions of the uploaded logo to a minimum.
Some logos are just simply text in one line and TMDB reduces them to a thin strip of text with no padding around the text at all. When aligny=bottom is used these logos sometimes sit just barely on top of the info section and this leaves a huge space above the logo empty.
Using aligny="center" nicely puts the logo in the center (vertically) leaving some space at the bottom and the top if needed.
For example, logos from TMDB and Fanart.tv for "Dynasties":
https://www.themoviedb.org/tv/82953-dynasties/images/logos
https://fanart.tv/series/352054/dynasties-2019/
See screenshots below for clarity - used logos from TMDB (since it's the default TV show scrapper for Kodi now):
Before Change:
After Change: