Partial IPv6 support?

[frafra]

Is IPv6 supported?

    self.sock.connect(( ip, port ))
socket.gaierror: [Errno -9] Address family for hostname not supported

Couldn't sock_family be detected automatically? Python 3 has the ipaddress module.

When I set sock_family to AF_INET6 I get another error:

  File "/home/frafra/.cache/pypoetry/virtualenvs/viltkamera-manager-QhDdi_a7-py3.8/lib/python3.8/site-packages/smb/SMBConnection.py", line 122, in connect
    self._pollForNetBIOSPacket(timeout)
  File "/home/frafra/.cache/pypoetry/virtualenvs/viltkamera-manager-QhDdi_a7-py3.8/lib/python3.8/site-packages/smb/SMBConnection.py", line 637, in _pollForNetBIOSPacket
    self.feedData(data)
  File "/home/frafra/.cache/pypoetry/virtualenvs/viltkamera-manager-QhDdi_a7-py3.8/lib/python3.8/site-packages/nmb/base.py", line 49, in feedData
    length = self.data_nmb.decode(self.data_buf, offset)
  File "/home/frafra/.cache/pypoetry/virtualenvs/viltkamera-manager-QhDdi_a7-py3.8/lib/python3.8/site-packages/nmb/nmb_structs.py", line 60, in decode
    raise NMBError("Invalid protocol header for Direct TCP session message")
nmb.nmb_structs.NMBError: Invalid protocol header for Direct TCP session message

is_direct_tcp is set to True as it looks to me that NetBIOS does not work in IPv6. Setting it to False produces a timeout.

smbclient works just fine instead.

[miketeo]

When you set is_direct_tcp=True, did you connect to port 445 ?

[frafra]

@miketeo You are right, thank you, the port was wrong indeed. I cannot try with IPv6 right now, but I would guess that will solve the issue.

[frafra]

It works if I use the IP address instead of the hostname, which has been specified in /etc/hosts.

[frafra]

I can confirm there is an issue with IPv6. IPv4 is assumed to be the default, so if I try to connect to hosts over IPv6, I need to specify that.

pysmb/python3/smb/SMBConnection.py

Line 98 in 0b0b9a7

def connect(self, ip, port = 139, sock_family = socket.AF_INET, timeout = 60):

pysmb/python3/smb/SMBConnection.py

Lines 111 to 113 in 0b0b9a7

	self.sock = socket.socket(sock_family)
	self.sock.settimeout(timeout)
	self.sock.connect(( ip, port ))

Wouldn't it better to use socker.create_server with support both IPv4 and IPv6?

self.sock = socket.create_connection(( ip, port ), timeout)

Reference: https://docs.python.org/3/library/socket.html#socket.create_connection