Avoid breaking patches by removing trailing whitespaces #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I haven't seen a good way to add a spec/test for this yet, and I realize the project doesn't have any specs either. |
|
To test if trailing new lines are preserved in patch files I would open a file with multiple lines that have trailing space characters. I would then force Atom to save that fill and then check if the trailing new lines are still present in the file. |
|
Thanks! I'll add specs for this and release. |
miketheman
added a commit
that referenced
this pull request
Oct 10, 2016
To support the changes in #6, this spec suite performs an empty diff file load, adds some text with trailing spaces, and saves it. With the default settings for the package, it should never trim whiespace if the whitespace package is enabled. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
|
Specs added and released in 0.6.0. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The atom whitespaces package removes trailing whitespace by default.
This setting file makes sure, that trailing whitespace are never automatically deleted on save, to avoid breaking patches on save.