Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend HeaderAuthentication #31

Closed
loju opened this issue May 26, 2020 · 5 comments
Closed

Extend HeaderAuthentication #31

loju opened this issue May 26, 2020 · 5 comments

Comments

@loju
Copy link

loju commented May 26, 2020

Some APis require more than one pair in header for authentication.
Would be nice, to provide more than one pair key value, eg: get them from dict.
@MikeWooster
Copy link
Owner

That's a fantastic idea. feel free to create a pull request for it. My only requirement is that we don't break backwards compatibility with the existing implementation.

@loju
Copy link
Author

loju commented Jun 16, 2020

Cool, one obstacle - I have no access to create dev branch.

@MikeWooster
Copy link
Owner

This might help you.
https://help.github.com/en/enterprise/2.16/user/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

@MikeWooster
Copy link
Owner

I made a quick fix to this. take a look at the rc version for 1.2.
https://pypi.org/project/api-client/1.2.0rc1/

@MikeWooster
Copy link
Owner

I have released v1.2.0. Hopefully this is flexible enough for your requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@loju @MikeWooster