Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tenacity 7.0 breaks test suite #61

Closed
peterschutt opened this issue Mar 17, 2021 · 2 comments
Closed

Tenacity 7.0 breaks test suite #61

peterschutt opened this issue Mar 17, 2021 · 2 comments

Comments

@peterschutt
Copy link
Contributor

peterschutt commented Mar 17, 2021

Tenacity has removed tenacity.compat.make_retry_state which features heavily in test_retrying.py.

from tenacity.compat import make_retry_state

To Reproduce

  1. Create new virtualenv and activate.
  2. python -m pip install .[test]
  3. pytest

Environment

(.venv) peter@petes-laptop:~/peterschutt/api-client$ python -m pip freeze
api-client @ file:///home/peter/peterschutt/api-client
attrs==20.3.0
certifi==2020.12.5
chardet==4.0.0
coverage==5.5
idna==2.10
iniconfig==1.1.1
multidict==5.1.0
packaging==20.9
pluggy==0.13.1
py==1.10.0
pyparsing==2.4.7
pytest==6.2.2
pytest-cov==2.11.1
pytest-env==0.6.2
PyYAML==5.4.1
requests==2.25.1
requests-mock==1.8.0
six==1.15.0
tenacity==7.0.0
toml==0.10.2
urllib3==1.26.4
vcrpy==4.1.1
wrapt==1.12.1
yarl==1.6.3

I've run out of time to look at a fix right now, but will do so at my next opportunity if you haven't already resolved.

@peterschutt
Copy link
Contributor Author

Prob need to include tenacity70 in tox envlist.

@MikeWooster
Copy link
Owner

fixed in #64

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants