Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: support for other Operating Systems #1

Open
1 of 3 tasks
Vyvy-vi opened this issue Dec 28, 2020 · 5 comments
Open
1 of 3 tasks

FEAT: support for other Operating Systems #1

Vyvy-vi opened this issue Dec 28, 2020 · 5 comments

Comments

@Vyvy-vi
Copy link

Vyvy-vi commented Dec 28, 2020

Description:

It would be great if we could extend this to other OSs:

  • macOS
  • Linux

Proposed approach:

Using sys.platform (or os.name) for finding which os file-system is running the script, and formatting the folder paths accordingly.

Would I be interested in working on this issue:

  • yes
@mikeysan
Copy link
Owner

Great idea @Vyvy-vi

Please go ahead and raise a PR.

I would ask that you please comment your code to help me and others understand your changes.

@Vyvy-vi
Copy link
Author

Vyvy-vi commented Dec 28, 2020

Slight update: This seems to work on other operating systems :)
(only the initial chgDir path needs to be altered to UNIX format)

I should have tested before opening an issue 🤦

@mikeysan
Copy link
Owner

I would still like to automate that bit somewhat.

I was actually thiniking I could ask the user to supply the full dev path as an input.

So one would still run the script using script.py folder, but the script willl then ask for a path from the user.
Depending on what platform you are on, you would provide a "/home/user/whatever" or "/Users/user/whatever" path and the folder argument will be created within that path.

Does that make sense?

That might be tough for Windows that needs he double slashes, though, but that's what I was thinking of doing later.

@Vyvy-vi
Copy link
Author

Vyvy-vi commented Dec 28, 2020

that sounds good 👍

@mikeysan
Copy link
Owner

You may want to do a git pull as I have created a new file which has the building blocks to what we're talking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants