Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktopography extractor #1740

Merged
merged 1 commit into from Sep 17, 2021

Conversation

Jackymancs4
Copy link
Contributor

Hello @mikf
recently I stumbled upon this site: https://desktopography.net/ which host a variety of high quality wallpaper in different resolutions.

So I created an extractor for it.

It supports

All files are saved as name_resolution.ext

I hope this is inline with the scope of the project.
If yes, upon review I expect the code to need to be cleaned up a bit.

Also, I'd appreciate some hints about what to do about the tests.

Thank you.

@mikf mikf merged commit 4a7d789 into mikf:master Sep 17, 2021
mikf added a commit that referenced this pull request Sep 17, 2021
@mikf
Copy link
Owner

mikf commented Sep 17, 2021

@Jackymancs4 Thank you very much.

I apologize for taking so long to merge this and to reply and get back to you. I didn't want to review and ask for changes and more work from your side after 1½ months, so I've simplified your code a bit myself, Mainly deleting unnecessary/commented lines and replacing your while loops with text.extract_iter(). (e4684c5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants