Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gfycat] Get post title #434

Closed
kattjevfel opened this issue Oct 1, 2019 · 2 comments
Closed

[gfycat] Get post title #434

kattjevfel opened this issue Oct 1, 2019 · 2 comments

Comments

@kattjevfel
Copy link
Contributor

Currently you cannot get the title for gfycat links, like you can with imgur posts, since there's no title tag (checked with -K).

Das problem und die lösung:
https://gfycat.com/massivesimilarbat-cat
is currently gfycat_MassiveSimilarBat.mp4
but would be gfycat_MassiveSimilarBat_Fighting A Losing Battle GIF.mp4

Or at least available for users to change in their config, but having it as default makes sense imo.

@mikf
Copy link
Owner

mikf commented Oct 2, 2019

But there already is a title metadata field:

$ gallery-dl -K https://gfycat.com/massivesimilarbat-cat
...
thumb100PosterUrl
  https://thumbs.gfycat.com/MassiveSimilarBat-mobile.jpg
title
  Fighting a losing battle
userName
  anonymous
...

and setting the filename format string accordingly works as it should:

$ gallery-dl -o filename="{category}_{gfyName}_{title}.{extension}" https://gfycat.com/massivesimilarbat-cat
/tmp/gfycat/gfycat_MassiveSimilarBat_Fighting a losing battle.mp4

but having it as default makes sense imo.

Agreed.

@kattjevfel
Copy link
Contributor Author

Reminder to self: Don't do bug reporting past midnight

Looking at my shell history I see I've done grep GIF but I realise now that's slapped on every post in the title of the webpage.. whoops.

@mikf mikf closed this as completed in 0ff90a3 Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants