Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to hentainexus: circle, event, title_conventional. #661

Merged
merged 1 commit into from Mar 31, 2020

Conversation

mo-han
Copy link
Contributor

@mo-han mo-han commented Mar 29, 2020

No description provided.

@mikf
Copy link
Owner

mikf commented Mar 31, 2020

Thanks a lot and apologies for all the trouble.

I should mention that it is almost possible to "create" the contents of title_conventional with gallery-dl's current formatting options, so I'm going to add that missing option and might also remove the title_conventional field, but I'm going to notify you here, if that happens.

The only thing missing is a closing bracket for artist when there is also a circle,
and the handling of an "empty" parody is a bit weird, but the rest works:

"{event:?(/) /}[{circle:?/ (/}{artist}] {title}{parody:ROriginal Work//? (/)/}{book:? (/)/}{magazine:? (/)/}"

@mikf mikf merged commit 6f81cac into mikf:master Mar 31, 2020
@mo-han
Copy link
Contributor Author

mo-han commented Apr 1, 2020

A conventional title is just a "convention", which means the community (the Japanese doujinshi and manga fan circle) has been using this title format for decades. People, us, expect the default title to be in such a format, not just for things on the hentainexus site, not only for the hentai comics, but also for the non-hentai art works.

It's not a redundancy, but a lack. Some sites already have the full title, like e-hentai, nhentai, etc. For those sites, simply using the present title can do the job. But can you imagine the frustration when we have to use some verbose text string option just to get a well formatted title? It's so unpythonic to use extra options to do a default thing.

title_conventional dosen't conflict the design philosophy or the software architecture or the option system of gallery-dl, it's just a convenient default.

If you decide to remove that key in release then I'll just have to make a manual patch whenever updating gallery-dl.

@mo-han
Copy link
Contributor Author

mo-han commented Apr 1, 2020

BTW, here is the script I use to download from hentainexus, calling the patched gallery-dl.exe.

@echo off
setlocal
set default_root=%locallib_usrdl%

if not defined root set root=%default_root%
pushd %root%
call proxy.set.cow.cmd
gallery-dl^
  -o base-directory=\"hentainexus\"^
  -o directory="[\"{title_conventional} [{language}][{publisher}][hentainexus.{gallery_id}]\"]"^
  -o path-restrict-replace=map^
  -R -1^
  %*
popd

If it's you who decide to download, which script do you prefer? The above one? Or the "{event:?(/) /}[{circle:?/ (/}{artist}] {title}{parody:ROriginal Work//? (/)/}{book:? (/)/}{magazine:? (/)/}" one?

@mo-han mo-han deleted the hentainexus-addmeta branch May 26, 2020 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants