Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version issue #3

Closed
Andes107 opened this issue Jan 15, 2021 · 20 comments
Closed

Version issue #3

Andes107 opened this issue Jan 15, 2021 · 20 comments

Comments

@Andes107
Copy link

It seems that this is a solution for the first edition. Since I am using the second edition, will you accept any edition on either editions?

@mikinty
Copy link
Owner

mikinty commented Jan 15, 2021

Hmm I'm pretty sure I used the second edition -- where do you see a discrepancy, and can you point out in detail where it is?

@mikinty
Copy link
Owner

mikinty commented Jan 15, 2021

Also if you have any ideas on how to deal with versioning, I would be open to that.

I would prefer things to stay as one PDF, but if versioning has too many differences, we can maybe split into multiple PDFs.

@Andes107
Copy link
Author

For example, the proof of Schroeder Bernstein theorem is required in 1.5.11 in my book. But in the main.pdf, it is 1.4.13. In addition, in my book, 1.5 is cardinality and 1.6 is cantor theorem.20210116_005708.jpg20210116_005654.jpg

@mikinty
Copy link
Owner

mikinty commented Jan 16, 2021

Ok since the first edition solutions are complete as is, how about we make an additional appendix that explains how the second edition corresponds with the first edition? And if there are any problems that are in the second edition but not in the first, we can do them in the appendix as well.

You can submit a PR for your changes, and let me know if you need help.

@Andes107
Copy link
Author

Do I need to be a contributor to push changes?

@mikinty
Copy link
Owner

mikinty commented Jan 23, 2021

No just fork and make all your changes there. Then when you're ready you can open a PR from your fork to this main repo.

@Zjmgpk
Copy link

Zjmgpk commented Aug 3, 2021

Is there one for the 2nd edition? Sorry if im bothering

@Andes107
Copy link
Author

Andes107 commented Aug 4, 2021

No, I am sorry.

@Zjmgpk
Copy link

Zjmgpk commented Aug 4, 2021

That's okay. Thanks at least for this edition.

@mikinty
Copy link
Owner

mikinty commented Aug 4, 2021

You are also free to contribute to make a second edition version, perhaps another branch

@Zjmgpk
Copy link

Zjmgpk commented Aug 4, 2021

If I ever can, I know I'd love to. Right now, I've mainly been looking for a solution manual for the 2nd edition due to taking real analysis this coming semester(fall 2021) so I can learn ahead.

@mikinty
Copy link
Owner

mikinty commented Aug 4, 2021

Well if you're truly learning ahead, you should be writing your own solutions manual :)

@mikinty
Copy link
Owner

mikinty commented Aug 4, 2021

Also, I'm pretty sure there are 2nd edition solution manuals online if you search hard enough, but I don't think you learn as much if you have one because it's hard to force yourself to really try

@Zjmgpk
Copy link

Zjmgpk commented Aug 4, 2021

I've looked around. There are only 1st editions from what I've found.

@Andes107
Copy link
Author

Andes107 commented Aug 5, 2021

@mikinty do you think it is possible for you to open a new branch for 2nd edition? In this case, @Zjmgpk can contribute? Hell, I can then contribute also.
Ever since I have learnt this github repo I have been replicating what you @mikinty have done in first edition but so far I have only detailed the first 2 chapters due to syntactic reasons. Needless to say, @mikinty 's syntax has opened my eyes in latex. And since I am familiar with git instead of github, I have gone off the radar. In particular, I am not so sure how can I merge my work with @mikinty in github.
@Zjmgpk , so far I have read 5 chapters in Abbott's book, most of which can be solved or found through internet. It is either Google such as some random university lecture material in pdf or mathematics stack exchange post.
Brace yourself, one of the skills to master is learning how to find a solution. Reading and understanding the solution is merely the second if my experience has taught me anything.

@mikinty
Copy link
Owner

mikinty commented Aug 5, 2021

Hi @Andes107,

Thank you for your work so far -- merging itself is quite simple on GitHub, and I can help you open the pull request for that.

All I need you to do is

  1. Fork the repo, let me know if you need help with this
  2. Clone the repo to your local computer
  3. Make a new branch
  4. Make the changes
  5. Commit the changes and push to your repo
  6. Open a pull request to this repo via GitHub UI

If this isn't possible, you can DM me what you have and I can put it together, but it would be a good exercise to learn some version control so you can contribute to this repo and others in the future.

@Andes107
Copy link
Author

Andes107 commented Aug 6, 2021

Hello @mikinty ,

I have just learnt what is fork and pull request. My 2 cents will be

  1. You create a branch for second edition
  2. Anyone can then fork your repo to their repo, clone their repo to their local machine
  3. Commit and push to second edition branch to their machine and their repo
  4. Ask for pull request to the upstream second branch

Now, the problem is, you mentioned about me directly forking and add a new branch that doesn't exist in upstream, according to this post, it seems impossible. But if I catch your drift, it seems possible. Can you elaborate in this regard?

@filippoitaliano
Copy link

@Andes107 you can fork this repo. At that point you'll have "your" repo. Then you can add and manage branches as you wish in your repo. When you'll want to update @mikinty repo, you'll create a pull request for asking to merge into master (or another branch I think). Keeping a different branch for keeping different material permanently is ugly at my point of view. Still, the decision will be @mikinty responsibility.

@UlisseMini
Copy link

I've been writing up my solutions https://github.com/ulissemini/understanding-analysis-solutions for the second edition, it isn't done yet but hopefully it's useful to someone! (PS: thanks mikinty I based the latex off this repo <3)

@mikinty
Copy link
Owner

mikinty commented Mar 13, 2022

It's been a while but @UlisseMini great work -- let's just keep the 2nd edition as a permanent fork

I don't think I'll be maintaining this repo that much tbh, lots of other interesting projects to do nowadays

LaTeX forever tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants