Skip to content

Commit

Permalink
Merge pull request #92 from testingsavvy/testDoubleMatrixRobustness
Browse files Browse the repository at this point in the history
org.jblas.TestDoubleMatrix::testColumnAndRowMinMax has inadequate loop coverage
  • Loading branch information
mikiobraun committed Feb 1, 2018
2 parents f435a6d + 4514b98 commit 281ad24
Showing 1 changed file with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions src/test/java/org/jblas/TestDoubleMatrix.java
Expand Up @@ -666,6 +666,30 @@ public void testColumnAndRowMinMax() {
assertEquals(2, i[3]);
}

@Test
public void testColumnAndRowMinMaxUnsorted() {
assertEquals(new DoubleMatrix(1, 3, -2.0, -6.0, -8.0), E.columnMins());
assertEquals(new DoubleMatrix(3, 1, -4.0, -8.0, -6.0), E.rowMins());
assertEquals(new DoubleMatrix(1, 3, 3.0, 5.0, 9.0), E.columnMaxs());
assertEquals(new DoubleMatrix(3, 1, 7.0, 5.0, 9.0), E.rowMaxs());
int[] i = E.columnArgmins();
assertEquals(1, i[0]);
assertEquals(2, i[1]);
assertEquals(1, i[2]);
i = E.columnArgmaxs();
assertEquals(2, i[0]);
assertEquals(1, i[1]);
assertEquals(2, i[2]);
i = E.rowArgmins();
assertEquals(1, i[0]);
assertEquals(2, i[1]);
assertEquals(1, i[2]);
i = E.rowArgmaxs();
assertEquals(2, i[0]);
assertEquals(1, i[1]);
assertEquals(2, i[2]);
}

@Test
public void testToArray() {
assertTrue(Arrays.equals(new double[]{2.0, 4.0, 8.0}, B.toArray()));
Expand Down

0 comments on commit 281ad24

Please sign in to comment.