Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make insecure config default a boolean instead of a string literal #86

Closed
rvdmei opened this issue Apr 12, 2023 · 3 comments
Closed

Make insecure config default a boolean instead of a string literal #86

rvdmei opened this issue Apr 12, 2023 · 3 comments
Labels

Comments

@rvdmei
Copy link

rvdmei commented Apr 12, 2023

I'm using plantuml-markdown with a private root CA on the plantuml server. This is installed properly on the system and overridden with environment variables for requests library, even copied to the location that certifi package is using.

With this setup I am still getting warnings from requests library that certificate verification is strongly advised.

After some checking I found that the parameters that session.post for the verify parameter should be a boolean, or location of a certificate bundle. The current default setting is a sting literal:

'insecure': ["False", "Disable SSL certificates verification; set to True if you server uses self-signed certificates. Defaults to False"],

Can this be changed to a simple False instead of "False" or will that break other things?

@mikitex70
Copy link
Owner

Hi @rvdmei, sure the default can be a boolean. This does not prevent of setting the variable as a path to a certificate, so I think there are no side effects.
Give a couple of hours, I think I can release the fix this night.

@rvdmei
Copy link
Author

rvdmei commented Apr 12, 2023

Awesome. I would have created a PR myself, but my employment contract would make the change not mine to give 😕

@mikitex70
Copy link
Owner

Just released version 3.8.3, now the default is a boolean False.
Thanks for your suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants