You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using plantuml-markdown with a private root CA on the plantuml server. This is installed properly on the system and overridden with environment variables for requests library, even copied to the location that certifi package is using.
With this setup I am still getting warnings from requests library that certificate verification is strongly advised.
After some checking I found that the parameters that session.post for the verify parameter should be a boolean, or location of a certificate bundle. The current default setting is a sting literal:
Hi @rvdmei, sure the default can be a boolean. This does not prevent of setting the variable as a path to a certificate, so I think there are no side effects.
Give a couple of hours, I think I can release the fix this night.
I'm using
plantuml-markdown
with a private root CA on the plantuml server. This is installed properly on the system and overridden with environment variables forrequests
library, even copied to the location thatcertifi
package is using.With this setup I am still getting warnings from requests library that
certificate verification is strongly advised
.After some checking I found that the parameters that
session.post
for theverify
parameter should be aboolean
, or location of a certificate bundle. The current default setting is a sting literal:plantuml-markdown/plantuml_markdown.py
Line 611 in e48b049
Can this be changed to a simple
False
instead of"False"
or will that break other things?The text was updated successfully, but these errors were encountered: