We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noticed this while doing #37
We are checking the session expiry time here - https://github.com/mikker/passwordless/blob/master/app/controllers/passwordless/sessions_controller.rb#L48 whereas it should use timeout_at. And, the expires_at should maybe used in the authenticate_by_cookie method instead. Correct me if I'm wrong, I may have misunderstood. If not, let me know, happy to send a PR.
timeout_at
expires_at
authenticate_by_cookie
The text was updated successfully, but these errors were encountered:
You're right. Good catch! PR is very welcome, thank you!
Sorry, something went wrong.
avinoth
Successfully merging a pull request may close this issue.
Noticed this while doing #37
We are checking the session expiry time here - https://github.com/mikker/passwordless/blob/master/app/controllers/passwordless/sessions_controller.rb#L48 whereas it should use
timeout_at
. And, theexpires_at
should maybe used in theauthenticate_by_cookie
method instead. Correct me if I'm wrong, I may have misunderstood. If not, let me know, happy to send a PR.The text was updated successfully, but these errors were encountered: