Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session Expires at is wrongly used #38

Closed
avinoth opened this issue Jan 27, 2019 · 1 comment · Fixed by #43
Closed

Session Expires at is wrongly used #38

avinoth opened this issue Jan 27, 2019 · 1 comment · Fixed by #43
Assignees
Labels

Comments

@avinoth
Copy link
Contributor

avinoth commented Jan 27, 2019

Noticed this while doing #37

We are checking the session expiry time here - https://github.com/mikker/passwordless/blob/master/app/controllers/passwordless/sessions_controller.rb#L48 whereas it should use timeout_at. And, the expires_at should maybe used in the authenticate_by_cookie method instead. Correct me if I'm wrong, I may have misunderstood. If not, let me know, happy to send a PR.

@mikker
Copy link
Owner

mikker commented Jan 27, 2019

You're right. Good catch! PR is very welcome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants