Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions support #80

Closed
wovalle opened this issue Sep 30, 2019 · 1 comment · Fixed by #81
Closed

Transactions support #80

wovalle opened this issue Sep 30, 2019 · 1 comment · Fixed by #81

Comments

@wovalle
Copy link
Contributor

wovalle commented Sep 30, 2019

Hey, first of all nice work with this library!

I did a naive implementation to support transactions and I'm monkey patching your library in my project. It doesn't have any special checks/corner cases, just exposes a compatible api for firestore transactions.

Would you be interested on a PR adding this transactions naive implementation to the library?

Thanks!
@mikkopaderes
Copy link
Owner

Thank you, I would appreciate that. 😃

@wovalle wovalle mentioned this issue Oct 2, 2019
Merged
@wovalle wovalle mentioned this issue Oct 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: adding naive transaction implementation
2 participants
@wovalle @mikkopaderes