Remove concat_ident! for module expressions, enable building on stable #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables rust-blas to build on Rust stable
skade
changed the title
This was referenced Dec 1, 2015
mikkyang
added a commit
that referenced
this pull request
Dec 2, 2015
Remove concat_ident! for module expressions, enable building on stable
|
Looks great! Thanks for the work. It's a pretty clever workaround for the modules. |
|
I would say prefixing names is a workaround for a lack of modules in C and this just unwraps the workaround :). I saw that you bumped a version - will you do a release soon? (asking for collenchyma) |
|
Yeah, I forgot to |
|
Perfect, thanks for all the work 👍 |
homu
added a commit
to autumnai/collenchyma
that referenced
this pull request
Dec 2, 2015
Move to stable This PR removes unnecessary use of feature flags that bar using Rust on stable([1])([2]) compilers. Reasons being: * associated consts (Tracking issue: rust-lang/rust#29646) are currently buggy and can be replaced by an fn in that case. * associated_type_defaults can be removed without breakage * unboxed_closures can be removed without breakage * StaticMutex has an uncertain future (rust-lang/rust#27717) and can be emulated in that case by using `lazy_static!` (correct me if I'm wrong) Finally, I must admit that I didn't get the test suite running quickly. ([1]) Outstanding: this doesn't _quite_ work on stable yet, as some APIs in use are currently making their way through beta, so they are not feature gated, but also not available in 1.4.0. 1.5.0 beta works and as 1.5.0 is 2 weeks away, this is probably not worth the effort. ([2]) rblas is not on stable yet, see mikkyang/rust-blas#12 for that. You can use that version of rust-blas by checking it out from my https://github.com/skade/rust-blas/ and dropping the following `.cargo/config` in your repository: ``` paths = ["/path/to/rblas/checkout"] ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables rust-blas to build on Rust stable.
This sorts the function prototypes in the FFI by group, and changes the
prefix!and similar macros to using the new modules instead ofconcat_indent!.The future of
concat_ident!is uncertain: rust-lang/rust#29599