Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A quick note to say thanks #1

Open
SebasQuirogaUCP opened this issue Feb 13, 2023 · 3 comments
Open

A quick note to say thanks #1

SebasQuirogaUCP opened this issue Feb 13, 2023 · 3 comments

Comments

@SebasQuirogaUCP
Copy link

Thank you for all your efford doing this and making it available to the public.
I git cloned it and it works perfectly.
I started watching the videos for a better understanding.

@DanTheComputerMan
Copy link

python_EPAIaAh4KK

My lack of chess skill aside, this project (and perhaps the original as well) has a bug in that the queen can save itself from a pin ... by allowing their king to be captured.

This is how the game ended:

python_q5vQRr5ks7

@Rupsero
Copy link

Rupsero commented Feb 9, 2024

python_EPAIaAh4KK

My lack of chess skill aside, this project (and perhaps the original as well) has a bug in that the queen can save itself from a pin ... by allowing their king to be captured.

This is how the game ended:

python_q5vQRr5ks7

Yep, I had the same problem.
Did you tried to fix that by any chance?

@Bazzz-1
Copy link

Bazzz-1 commented Jun 29, 2024

Not sure if this would solve your problem but I found you need to call self.getRookMoves before self.getBishopMoves under the getQueenMoves function otherwise the queen doesn't pin correctly.

But yeah otherwise this code has saved me a boatload of coding time haha, big thank you to Mikolaj! <3
Very well put together. The separation between UI and chess engine was a great idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants