Transaction query already complete, run with DEBUG=knex:tx for more info ; Zone: <root> ; Task: Promise.then ; Value: Error: Transaction query already complete, run with DEBUG=knex:tx for more info

[SDAdham]

Describe the bug
A clear and concise description of what the bug is.
Happens at findOne and it happens randomly and this started to happen since 4.5.7, it was stable with 4.5.5
I enabled DEBUG=knex:tx but it wasn't really that useful.

Stack trace

Unhandled Promise rejection: Transaction query already complete, run with DEBUG=knex:tx for more info ; Zone: <root> ; Task: Promise.then ; Value: Error: Transaction query already complete, run with DEBUG=knex:tx for more info
    at completedError (/builds/app/node_modules/knex/lib/transaction.js:358:9)
    at /builds/app/node_modules/knex/lib/transaction.js:324:24
    at new ZoneAwarePromise (/builds/app/node_modules/zone.js/bundles/zone.umd.js:1340:33)
    at Client_MySQL.trxClient.query (/builds/app/node_modules/knex/lib/transaction.js:320:12)
    at Runner.query (/builds/app/node_modules/knex/lib/runner.js:151:36)
    at /builds/app/node_modules/knex/lib/runner.js:40:23
    at /builds/app/node_modules/knex/lib/runner.js:277:24
    at ZoneDelegate.invoke (/builds/app/node_modules/zone.js/bundles/zone.umd.js:400:30)
    at Zone.run (/builds/app/node_modules/zone.js/bundles/zone.umd.js:160:47)
    at /builds/app/node_modules/zone.js/bundles/zone.umd.js:1318:38 Error: Transaction query already complete, run with DEBUG=knex:tx for more info
    at completedError (/builds/app/node_modules/knex/lib/transaction.js:358:9)
    at /builds/app/node_modules/knex/lib/transaction.js:324:24
    at new ZoneAwarePromise (/builds/app/node_modules/zone.js/bundles/zone.umd.js:1340:33)
    at Client_MySQL.trxClient.query (/builds/app/node_modules/knex/lib/transaction.js:320:12)
    at Runner.query (/builds/app/node_modules/knex/lib/runner.js:151:36)
    at /builds/app/node_modules/knex/lib/runner.js:40:23
    at /builds/app/node_modules/knex/lib/runner.js:277:24
    at ZoneDelegate.invoke (/builds/app/node_modules/zone.js/bundles/zone.umd.js:400:30)
    at Zone.run (/builds/app/node_modules/zone.js/bundles/zone.umd.js:160:47)
    at /builds/app/node_modules/zone.js/bundles/zone.umd.js:1318:38
This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason:
Error: Transaction query already complete, run with DEBUG=knex:tx for more info
    at completedError (/builds/app/node_modules/knex/lib/transaction.js:358:9)
    at /builds/app/node_modules/knex/lib/transaction.js:324:24
    at new ZoneAwarePromise (/builds/app/node_modules/zone.js/bundles/zone.umd.js:1340:33)
    at Client_MySQL.trxClient.query (/builds/app/node_modules/knex/lib/transaction.js:320:12)
    at Runner.query (/builds/app/node_modules/knex/lib/runner.js:151:36)
    at /builds/app/node_modules/knex/lib/runner.js:40:23
    at /builds/app/node_modules/knex/lib/runner.js:277:24
    at ZoneDelegate.invoke (/builds/app/node_modules/zone.js/bundles/zone.umd.js:400:30)
    at Zone.run (/builds/app/node_modules/zone.js/bundles/zone.umd.js:160:47)
    at /builds/app/node_modules/zone.js/bundles/zone.umd.js:1318:38
...

To Reproduce
Steps to reproduce the behavior:
it occurs at random

1. ...
2. ...
3. ...

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

Versions

Dependency	Version
node	14.17.3
typescript	4.3.5
mikro-orm	4.5.7
your-driver	4.5.7 (mysql/mariadb)

[B4nan]

Steps to reproduce the behavior:
it occurs at random

You will never get any help if you create issues like this. stack trace != reproduction.

[SDAdham]

@B4nan I am not using knex, only mikro-orm does, and I can see mikro-orm is not showing up in the stacktrace so I understand where you coming from, but can you please check the implementations of findOne and find and see if it matches with https://stackoverflow.com/a/64338029/5224768 ? I'll appreciate it.

[B4nan]

knex.transaction() is not used in either way internally, we use it in AbstractSqlConnection.begin() method only, using the tx context (the return value) instead of callback.

Things like this usually point to wrong usage of request contexts, especially when you see it happen randomly. Even if it was working fine in previous version does not mean your code is correct - but without seeing the code, I have no idea.

There were several issues about same error from knex, mostly caused by using EM inside hooks or with nested transactions, maybe you are doing that somewhere.