You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I went ahead with #3989 some time ago, but I keep thinking whether it was the right move. I still consider this a valid problem, but it feels like removing just the flush method could be enough. I also feel like not that many people were aware of the change by that time.
One argument for this I have is that technically, it's already possible to persist entities via a repository (em.create will call persist automatically).
So asking one more time, whether I should put those back as a last-minute change.
The flush method will stay only on the EM level.
Should we add the `persist` and `remove` methods back to the `EntityRepository` interface?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I went ahead with #3989 some time ago, but I keep thinking whether it was the right move. I still consider this a valid problem, but it feels like removing just the
flushmethod could be enough. I also feel like not that many people were aware of the change by that time.One argument for this I have is that technically, it's already possible to persist entities via a repository (
em.createwill call persist automatically).So asking one more time, whether I should put those back as a last-minute change.
The
flushmethod will stay only on the EM level.44 votes ·
Beta Was this translation helpful? Give feedback.
All reactions