Count work when no result is found #1135
Conversation
This should fix when grouping and no result is found
|
To maintain the full branch coverage, this will either need a test case (that would otherwise fail without that change) or at least ignore hint for istanbul (as using optional chaining usually reports missed branches due to how it is transpiled). |
| @@ -174,7 +174,7 @@ export abstract class AbstractSqlDriver<C extends AbstractSqlConnection = Abstra | |||
| .where(where); | |||
| const res = await this.rethrow(qb.execute('get', false)); | |||
|
|
|||
| return +res.count; | |||
| return +res?.count || 0; | |||
There was a problem hiding this comment.
Is it even possible that res will not be defined? I don't think so...
There was a problem hiding this comment.
this is what happened to me. Sorry I should have filed a bug actually
There was a problem hiding this comment.
I'm running this
await this.myRepository.count(
{ externalId: externalId },
{ groupBy: 'user' },
);
this fails if there's no entry in myRepository that satisfies the condition. The error says cannot read count of undefined
There was a problem hiding this comment.
ok then add the test case so we have that covered, to one of the EntityManager tests, em.count should be covered in all of them, so just extend the test that is already there
There was a problem hiding this comment.
we might still need that istanbul ignore hint, as covering lines with optional chaining is buggy
There was a problem hiding this comment.
do you plan to finish this or should I take over?
There was a problem hiding this comment.
Oh sorry, I had no time to look at this. If you can take over would be great
There was a problem hiding this comment.
Cant replicate this. More importantly, using count with groupBy will pretty much never give you what you want. Grouping will result in multiple rows, but em.count() will give you only the first one. It already uses count distinct query, what do you need the group by for?
edit: Ok got it, the issue is with the filter that will result in no results found, together with group by you end up with no rows. still what I said above applies, it's not doing what you are expecting most probably.
This should fix when grouping and no result is found