fix(cli): validate configuration in CLI cache commands #2146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures the configuration is checked for validity when executing the affected commands. Fixes #2145
|
I am quite sure this had a reason, otherwise I would not do this is a separate commit, but as the commit message is empty 🤦... Let's hope it was due to something that already changed (introduced in v3.0.0), but to be safe let's keep this v5 only. |
B4nan
changed the title
|
@B4nan Thanks for merging. I suspected that there would be a good reason for this. I assume it was because using these two commands doesn't require database details. So you might want to build the metadata cache in an environment that doesn't even have a database. In such a case you'd be required to put dummy configuration in the file to pass validation. I felt it would be more beneficial to run the validation though. As an invalid configuration can lead to all kinds of confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the configuration is checked for validity when executing the affected commands.
Fixes #2145